Add Source Freshness Results #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
michelley-an
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
michelley-an
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
michelley-an
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
michelley-an
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
dpguthrie
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
dpguthrie
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
llifoawing
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Hi @dpguthrie - need to add some logic to handle cases when warn_after or error_after configs are not set.
| '{{ source.node.name }}', {# name #} | ||
| '{{ source.node.source_name }}', {# source_name #} | ||
| '{{ source.node.loaded_at_field }}', {# loaded_at_field #} | ||
| {{ source.node.freshness.warn_after.count }}, {# warn_after_count #} |
There was a problem hiding this comment.
Suggested change
| {{ source.node.freshness.warn_after.count }}, {# warn_after_count #} | |
| {{ 'null' if source.node.freshness.warn_after.count is none else source.node.freshness.warn_after.count }} |
Was throwing an error when warn after not provided
| '{{ source.node.source_name }}', {# source_name #} | ||
| '{{ source.node.loaded_at_field }}', {# loaded_at_field #} | ||
| {{ source.node.freshness.warn_after.count }}, {# warn_after_count #} | ||
| '{{ source.node.freshness.warn_after.period }}', {# warn_after_period #} |
There was a problem hiding this comment.
Suggested change
| '{{ source.node.freshness.warn_after.period }}', {# warn_after_period #} | |
| {% if source.node.freshness.warn_after.period is none %} null {% else %} '{{ source.node.freshness.warn_after.period }}' {% endif %}, {# warn_after_period #} |
Handle None values
| '{{ source.node.loaded_at_field }}', {# loaded_at_field #} | ||
| {{ source.node.freshness.warn_after.count }}, {# warn_after_count #} | ||
| '{{ source.node.freshness.warn_after.period }}', {# warn_after_period #} | ||
| {{ source.node.freshness.error_after.count }}, {# error_after_count #} |
There was a problem hiding this comment.
Suggested change
| {{ source.node.freshness.error_after.count }}, {# error_after_count #} | |
| {{ 'null' if source.node.freshness.error_after.count is none else source.node.freshness.error_after.count }}, {# error_after_count #} |
Handle None values
| {{ source.node.freshness.warn_after.count }}, {# warn_after_count #} | ||
| '{{ source.node.freshness.warn_after.period }}', {# warn_after_period #} | ||
| {{ source.node.freshness.error_after.count }}, {# error_after_count #} | ||
| '{{ source.node.freshness.error_after.period }}', {# error_after_period #} |
There was a problem hiding this comment.
Suggested change
| '{{ source.node.freshness.error_after.period }}', {# error_after_period #} | |
| {% if source.node.freshness.error_after.period is none %} null {% else %} '{{ source.node.freshness.error_after.period }}' {% endif %}, {# error_after_period #} |
Handle None value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds source freshness executions to the package. This was recently added into dbt-core and now if the user opts into this behavior (adding a specific flag in their dbt_project.yml file), the
Resultsobject will be populated with SourceFreshnessResults. The behavior is very similar to all of the other_executionstables/models.Update type - breaking / non-breaking
What does this solve?
#166
Outstanding questions
The schema is slightly different than all of the other
_executionstables. Happy to change that, it just seemed that 1) some of the info wasn't relevant and 2) there's additional info we need to capture.What databases have you tested with?